search

tbbooher / new_cfa

new cfa site
MIT License
0 stars 0 forks source link

Format/Layout Coaches Page #3

Closed tbbooher closed 9 years ago

tbbooher commented 9 years ago

Tim needs to code up the wordpress backend for the coaches page.

tbbooher commented 9 years ago

screenshot 2014-11-21 05 20 32

tbbooher commented 9 years ago

made the page -- just going to display coaches first, float formatting help @BeyondHyper ?

derick-montague commented 9 years ago

I will build the html and css for you.

tbbooher commented 9 years ago

thanks! please do . . . using bootstrap . . .

navkum58 commented 9 years ago

Update coach page posts . Please review the commit and revert.

derick-montague commented 9 years ago

I said I would do this, so I will clean it up. The current code is not responsive and will not scale. The PHP and code is a bit messy. I will build an html file using the bootstrap grid.

navkum58 commented 9 years ago

BeyondHyper Hi, can we have scale screen where this Bootstrap - code is not responsive.

Thanks,

derick-montague commented 9 years ago

It's not responsive because the bootstrap grid was not used. The coach_float class is where your issue is. It will always be two columns. You need to rely on the grid to take care of that for you. Unfortunately, with bootstrap, many times the markup will be a bit bloated, but it's the payoff for using a frame work.

derick-montague commented 9 years ago

I was expceting something simple like:

<div class="row"> <div class="col-md-6"> <div class="row"> <div class="col-md-5">coach.img.jpg</div> <div class="col-md-7">Coach name<br/> Email icon and address</div> </div> <div class="row"> Coach info </div> </div>

</div>

navkum58 commented 9 years ago

Thanks, You just have to remove class col-sm-6 from coach post which I add as per Bootstrap media for tab N less.

It will work as you require coach.img.jpg Coach name Email icon and address Coach info

derick-montague commented 9 years ago

Well, no, the coach_float class needs to be removed and replaced with the col-md-6 and the other grid styles for the different break points. There is php method calls that inject markup to clear floats. I'm not going to make changes to the php code. I am just making a suggestion on markup that scales.

navkum58 commented 9 years ago

Thanks, will keep in mind :+1:

derick-montague commented 9 years ago

Actually, I'm almost done with the change, including the PHP change.

derick-montague commented 9 years ago

I'm done and checked in @tbbooher, I updated the layout and the SCSS and style sheet. You should not have any issues. I didn't compile, but it's basic and it'll be easier to merge in. There is an issue with the custom fields and they emails are not being pulled in. I didn't work on that, just the layout. I just wanted to bring it to your attention.

tbbooher commented 9 years ago

I will bring in the styles . . . thanks for your update.

On Wed, Dec 3, 2014 at 1:34 AM, Derick Montague notifications@github.com wrote:

I'm done and checked in @tbbooher https://github.com/tbbooher, I updated the layout and the SCSS and style sheet. You should not have any issues. I didn't compile, but it's basic and it'll be easier to merge in. There is an issue with the custom fields and they emails are not being pulled in. I didn't work on that, just the layout. I just wanted to bring it to your attention.

— Reply to this email directly or view it on GitHub https://github.com/tbbooher/new_cfa/issues/3#issuecomment-65362016.

-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Tim Booher www.theboohers.org | tim@theboohers.org 703.649.4264 (home) (703) 822-7863 (mobile)

tbbooher commented 9 years ago

working very well.