search

tbep-tech / tbeptools

R package for Tampa Bay Estuary Program functions
https://tbep-tech.github.io/tbeptools/
Other
7 stars 3 forks source link

[JOSS Review] Testing on MacOS? #45

Closed paleolimbot closed 3 years ago

paleolimbot commented 3 years ago

It looks like you're skipping MacOS on your GitHub Actions...I'm guessing because of the latest issues with sf building. If that is the case, you can conditionally make GitHub actions install the binary version of sf until the build issue has been solved (see https://github.com/paleolimbot/wk/blob/master/.github/workflows/R-CMD-check.yaml#L69-L70 ). I know this is just temporary but I do think it's important to make sure your package will work on MacOS + Windows + Linux.

(Linking https://github.com/openjournals/joss-reviews/issues/3485 )

fawda123 commented 3 years ago

Appears to be working now. 33610ed76a2e54e4b90050ddfc421aa7029076ee