search

tbeswick96 / BannerlordYetAnotherPartyOrganiser

Mount & Blade II: Bannerlord - Troop Manager Mod
GNU Lesser General Public License v3.0
6 stars 0 forks source link

Failed to save sorter configuration on exiting practice fight #43

Open MLNW opened 4 years ago

MLNW commented 4 years ago

When dying in the practice arena and then exiting by hitting tab instead of waiting for the game to automatically respawn the player there seems to be an issue with the sorter configuration.

Generally I would not expect that the settings are written to in this instance anyway.

EDIT: Same thing just happened upon exiting the smithing view and after winning a tournament

Expected Behaviour

No error on exiting the practice arena through tab.

Actual Behaviour

The error attached below

Steps to Reproduce

Screenshots

Seems like it may be related to a hard coded path that is not existent on my machine:

image

MLNW commented 4 years ago

Might be related to this line: https://github.com/tbeswick96/BannerlordYetAnotherPartyOrganiser/blob/336baba3faa818e3226ff05b890bb7e31333c73a/Extension/Configuration/SorterConfigurationJsonService.cs#L13

tbeswick96 commented 4 years ago

Welcome back :D

Yes I had this too, the game is autosaving on those exit events and sometimes I think it is either because the file is open in an editor, or it tries to save a few times at the same time. I was using a fire and forget task for this, but I have changed this on my local version but not release. I've not had the issue since.

I will update this reasonably soon to fix, however I've moved to MCM and it's currently in beta until its latest version (v4) stabilises.

tbeswick96 commented 4 years ago

@MLNW Should be sorted with 1.5.0