search

tbeu / matio

MATLAB MAT File I/O Library
https://matio.sourceforge.io
BSD 2-Clause "Simplified" License
330 stars 97 forks source link

Fix CMake shared linker options on macOS #174

Closed MaartenBent closed 3 years ago

MaartenBent commented 3 years ago

See #172

The linker on macOS does not recognize the used linker options, so use different options that should have the same effect. The exported_symbols_list option does not work with the names in matio.sym, it requires symbol names starting with _, so create a copy of matio.sym and modify it when necessary. Symbol names starting with _ also works with the GNU linker but not with the LLVM Linker on Linux, so don't modify the original file.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 82.325% when pulling 8b220fde8de36c7baed8feb908a88e03a58d055d on MaartenBent:cmake-macos-link into f93a57597c9df27bbce98b6a9a4e24ebd205eca1 on tbeu:master.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 82.325% when pulling c80718f4259654bdf40688ef3b21f92faa265e6c on MaartenBent:cmake-macos-link into f93a57597c9df27bbce98b6a9a4e24ebd205eca1 on tbeu:master.

MaartenBent commented 3 years ago

Error seems not related to my CMake changes, but something related to conan/python (maybe it requires python3?).

tbeu commented 3 years ago

Thank you for the PR. Should we have a macos+CMake build at Travis CI, too?

tbeu commented 3 years ago

Error seems not related to my CMake changes, but something related to conan/python (maybe it requires python3?).

Yes, I already noticed and thought it is related to the Conan cache. But Py3 is another useful hint.

MaartenBent commented 3 years ago

Thank you for the PR. Should we have a macos+CMake build at Travis CI, too?

Sure, let me add it.

tbeu commented 3 years ago

Sure, let me add it.

Thank you. Very diligent work.