Closed papadop closed 4 years ago
appveyor build fails, but I do not think I'm responsible....
I'm very cuirous about this, thanks!
I restarted the appveyor build.
Some options are also missing.
Why did you introduce matio_noreturn.h? If there is no need to touch it, please keep it as it is.
To factor this piece of code between the matio_pubconf.h.in and matio_pubconf_cmake.in. In this way the two files only contain defines (and includres). It is also simpler to check the correspondance between the defined variables (which by the way I need to check if there were updates in this respact since I did the original cmake port).
I still prefer to have a single pubconfig file and not distributed config files.
On MSVC I get an error that the folder getopt
does not contain a CMakeLists.txt file.
Ok, I found a simple CMakeLists.txt
for getopt. Now I'm still stuck at:
snprintf.c.obj : error LNK2019: unresolved external symbol va_copy referenced in function rpl_vasprintf
Are there extra libraries that need to be linked on Windows? The cmake-generated matioConfig.h
defines HAVE_VA_COPY
and undefines HAVE___VA_COPY
, so I think that its correct.
Please consider PR https://github.com/tbeu/matio/pull/75 that addresses several of the above problems.
I just pushed the one from OpenMEEG-matio... It should work out of the box as we regularly build this version of matio on windows...
Is this still being worked on? If not, I propose to close it w/o merge?
Is this still being worked on? If not, I propose to close it w/o merge?
Doing so.
This is only WIP for now. All comments accepted ! The cmake build system is added. I verified it build both in old fashion and with cmake. Tests with cmake are currently both incomplete (2018 tests instead of 3152) and sometimes wrong (180 tests out of 2018 are failing). I'm working on it.