tbeu / matio

MATLAB MAT File I/O Library
https://matio.sourceforge.io
BSD 2-Clause "Simplified" License
334 stars 97 forks source link

New cmake branch #74

Closed papadop closed 4 years ago

papadop commented 6 years ago

This is only WIP for now. All comments accepted ! The cmake build system is added. I verified it build both in old fashion and with cmake. Tests with cmake are currently both incomplete (2018 tests instead of 3152) and sometimes wrong (180 tests out of 2018 are failing). I'm working on it.

papadop commented 6 years ago

appveyor build fails, but I do not think I'm responsible....

emmenlau commented 6 years ago

I'm very cuirous about this, thanks!

tbeu commented 6 years ago

I restarted the appveyor build.

papadop commented 6 years ago

Some options are also missing.

tbeu commented 6 years ago

Why did you introduce matio_noreturn.h? If there is no need to touch it, please keep it as it is.

papadop commented 6 years ago

To factor this piece of code between the matio_pubconf.h.in and matio_pubconf_cmake.in. In this way the two files only contain defines (and includres). It is also simpler to check the correspondance between the defined variables (which by the way I need to check if there were updates in this respact since I did the original cmake port).

tbeu commented 6 years ago

I still prefer to have a single pubconfig file and not distributed config files.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 81.008% when pulling dd6566c0128671e2955f7a8e822df987876f4b70 on papadop:NewCmakeBranch into c9fa3a2029bed44fdf37eb4de8413521f635e3dc on tbeu:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 81.008% when pulling dd6566c0128671e2955f7a8e822df987876f4b70 on papadop:NewCmakeBranch into c9fa3a2029bed44fdf37eb4de8413521f635e3dc on tbeu:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 81.008% when pulling dd6566c0128671e2955f7a8e822df987876f4b70 on papadop:NewCmakeBranch into c9fa3a2029bed44fdf37eb4de8413521f635e3dc on tbeu:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 81.008% when pulling dd6566c0128671e2955f7a8e822df987876f4b70 on papadop:NewCmakeBranch into c9fa3a2029bed44fdf37eb4de8413521f635e3dc on tbeu:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 81.008% when pulling dd6566c0128671e2955f7a8e822df987876f4b70 on papadop:NewCmakeBranch into c9fa3a2029bed44fdf37eb4de8413521f635e3dc on tbeu:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 81.008% when pulling dd6566c0128671e2955f7a8e822df987876f4b70 on papadop:NewCmakeBranch into c9fa3a2029bed44fdf37eb4de8413521f635e3dc on tbeu:master.

emmenlau commented 6 years ago

On MSVC I get an error that the folder getopt does not contain a CMakeLists.txt file.

emmenlau commented 6 years ago

Ok, I found a simple CMakeLists.txt for getopt. Now I'm still stuck at:

snprintf.c.obj : error LNK2019: unresolved external symbol va_copy referenced in function rpl_vasprintf

Are there extra libraries that need to be linked on Windows? The cmake-generated matioConfig.h defines HAVE_VA_COPY and undefines HAVE___VA_COPY, so I think that its correct.

emmenlau commented 6 years ago

Please consider PR https://github.com/tbeu/matio/pull/75 that addresses several of the above problems.

papadop commented 6 years ago

I just pushed the one from OpenMEEG-matio... It should work out of the box as we regularly build this version of matio on windows...

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-81.1%) to 0.0% when pulling d74d2071e5eab0b20f3b61f6390269ccc90da923 on papadop:NewCmakeBranch into bdb6adf7a4935fce6b6d8393eb488ee95cdb018e on tbeu:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-81.1%) to 0.0% when pulling 892fa0d623a9efe0b791ae861072eea3ad540732 on papadop:NewCmakeBranch into bdb6adf7a4935fce6b6d8393eb488ee95cdb018e on tbeu:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-81.1%) to 0.0% when pulling d0a5ac81289d40d91a1666a9d94e29ef8add57d9 on papadop:NewCmakeBranch into bdb6adf7a4935fce6b6d8393eb488ee95cdb018e on tbeu:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-81.1%) to 0.0% when pulling d0a5ac81289d40d91a1666a9d94e29ef8add57d9 on papadop:NewCmakeBranch into bdb6adf7a4935fce6b6d8393eb488ee95cdb018e on tbeu:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-81.1%) to 0.0% when pulling d0a5ac81289d40d91a1666a9d94e29ef8add57d9 on papadop:NewCmakeBranch into bdb6adf7a4935fce6b6d8393eb488ee95cdb018e on tbeu:master.

tbeu commented 6 years ago

Is this still being worked on? If not, I propose to close it w/o merge?

tbeu commented 4 years ago

Is this still being worked on? If not, I propose to close it w/o merge?

Doing so.