Move tests into their own directory to cleanup the test directory.

tbeu / matio

MATLAB MAT File I/O Library

https://matio.sourceforge.io

BSD 2-Clause "Simplified" License

334 stars 97 forks source link

Move tests into their own directory to cleanup the test directory. #85

Closed papadop closed 6 years ago

papadop commented 6 years ago

I know that you were not so keen to this change in the cmake branch, but I think it make the test directory cleaner and more readable, so I attempted to isolate this change and propose it separately from the cmake branch. In addition, test/Makefile.am is slightly improved by adding some variables, which make it -- in a minor fashion as I do not expect dirname changes so often -- easier to maintain...

Fully tested on linux fedora-27 x86-64 with no regressions (no matlab tests, but I do not see how those would specially fail when all others are succeeding).

tbeu commented 6 years ago

I guess you forgot to adapt testsuite.at.

papadop commented 6 years ago

Strange, it worked on my computer. There is in theory no testsuite.at change as we just specify a test include directory in the Makefile.am. I'll investigate....

papadop commented 6 years ago

Indeed I forgot to update the -I in the autotest command line. The last commit should correct it. I dp not know why it worked when I tested it. Maybe I used a wrong repository (I have many) or forgot to update with autoreconf. Let's see if tarvis passes now. Note that this also shows one advantage of cmake build. When it is finished the testsuite will also work for windows builds.... I just realized yesterday that the testsuite was unix/macos only....

coveralls commented 6 years ago

Coverage remained the same at 81.189% when pulling af155c48d690a5705a686bc5f065c6cd34464b6f on papadop:TestsReorg into 6600c3d22cb9a71d1002d98de4656fb5905c4b6b on tbeu:master.