search

tbeu / matio

MATLAB MAT File I/O Library
https://matio.sourceforge.io
BSD 2-Clause "Simplified" License
334 stars 97 forks source link

Correct an overflow bug in Read5. #92

Closed papadop closed 6 years ago

papadop commented 6 years ago

This simple patch corrects issue #91.

massich commented 6 years ago

can we backport such fix to the current release and then add it to the conda package?

tbeu commented 6 years ago

Who is meant by "we"? But yes, I can cherry-pick it for the 1.5.12-branch.

massich commented 6 years ago

we -> anyone from the community with enough rights to do so. (aka tbeu)

massich commented 6 years ago

meanwhile you can merge this one https://github.com/conda-forge/libmatio-feedstock/pull/20 and then propagate the changes.

tbeu commented 6 years ago

Done, see https://github.com/tbeu/matio/tree/matio_1_5_12.

massich commented 6 years ago

but this one https://github.com/tbeu/matio/releases/tag/v1.5.12 still points to 6600c3d rather than 08873eb. While we update this, and the recipies. Can you merge https://github.com/conda-forge/libmatio-feedstock/pull/20

I'll submit a new PR reverting the patch and using the new release

tbeu commented 6 years ago

Well, I will not touch the tag for sure.