search

tbeu / matio

MATLAB MAT File I/O Library
https://matio.sourceforge.io
BSD 2-Clause "Simplified" License
334 stars 97 forks source link

Write backwards compatible Mat7.3 files #93

Closed StefanBruens closed 5 years ago

StefanBruens commented 5 years ago

When Matio uses HDF5 1.10.x, it may create files using features only supported with newer versions. Limiting the version range for compatibility was added in HDF5 1.10.2. For details, see https://www.hdfgroup.org/2018/04/why-should-i-care-about-the-hdf5-1-10-2-release/

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 78.988% when pulling 5e8d55937b3598b9a2946226a293d7736fca0c36 on StefanBruens:master into 87a3311f26b4d63090172903a9a30d4d7b91f23a on tbeu:master.

tbeu commented 5 years ago

Thanks for the PR. I wonder why the new lines https://coveralls.io/builds/19311752/source?filename=src/mat73.c#L2209 and https://coveralls.io/builds/19311752/source?filename=src/mat.c#L415 are not covered. Does H5F_LIBVER_V18 need to be set explicitly?

StefanBruens commented 5 years ago

Thanks for the PR. I wonder why the new lines https://coveralls.io/builds/19311752/source?filename=src/mat73.c#L2209 and https://coveralls.io/builds/19311752/source?filename=src/mat.c#L415 are not covered. Does H5F_LIBVER_V18 need to be set explicitly?

Unfortunately, the preprocessor check was wrong, H5F_LIBVER_V18 is an enum value and thus undefined from the preprocessors point of view.

Changed the check to H5_VERSION_GE(1,10,2), which has the intended effect.

tbeu commented 5 years ago

Resolved by cc80e26cee1665ff8f0afae81268e75257f9f39d. Thanks.

StefanBruens commented 5 years ago

Sorry for not fixing it, completely forgot to...