search

tbfleming / jscut

In-browser CAM package
http://jscut.org
GNU General Public License v3.0
302 stars 141 forks source link

Make all inches/mm #38

Closed tiger12506 closed 8 years ago

tiger12506 commented 9 years ago

jscut-1

From my perspective, it looks like the "Make all mm" and "Make all inch" links should convert, but the drop-down should not convert, just read the current values as the specified units.

This is currently not the case, as both the drop-down and the link convert the values in the fields.

g19fanatic commented 9 years ago

I believe having two ways of changing is unnecessarily redundant. I would opt for changing the drop-down to a label to declare what unit is being used and just keep the "Make all" actions.

tbfleming commented 9 years ago

There are multiple independent units fields. The "Make all" links set all of them at once.

tiger12506 commented 9 years ago

Ok, so this doesn't actually duplicate functionality then, because the Make all links affect more than just the Material grouping. Got it. I'd still be interested in a "change how we interpret the numbers without converting the numbers" feature, but certainly not a deal-breaker in any way, of course.

I greatly appreciate the work you are doing here.