illegal temp file name when diffing from server root

[GoogleCodeExporter]

Reported on the mailing list here:
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=30914
36

{{Summary}}
TortoiseSVN's 'Changed Files' dialog (Diff) fails to show differences
when showing a difference between an SVN Root for a particular revision.
The root cause seems to be the desire of the tool to rename the temp
file with a reserved Windows file name character.

{{Reproducible?}}
Yes

{{Steps To Reproduce}}
Attempt to perform a diff between two revisions when the path is the
"root" address:

TortoiseProc.exe /command:diff /path:"svn://svnserver:1234" /startrev:92016 
/endrev:92017

Attempting to double click on a file to show the diff will result in an
error similar to the following:

---------------------------
TortoiseSVN
---------------------------
Can't move 'S:\Users\aceo\AppData\Local\Temp\svn-1237D7F9' to
 'S:\Users\aceo\AppData\Local\Temp\svnserver:1234-rev92016.svn000.tmp': The
 filename, directory name, or volume label syntax is incorrect.
---------------------------
OK
---------------------------

{{Work Around}}
Do not attempt to perform the diff at the root, rather try to perform
the action at a level below root; IE:

TortoiseProc.exe /command:diff /path:"svn://svnserver:1234/trunk" 
/startrev:92016 /endrev:92017

{{Bug Previously Reported?}}
Not as far as I can see.

{{Version(s)}}
Issue appears to be present in the latest stable build of TortoiseSVN
1.8.8, Build 25755 - 64bit , 2014/08/10 14:44:06 downloaded from the
official TortoiseSVN site. This was running on Windows 7 SP1 x64 with
the latest updates applied.

{{Contact}}
Reported on the vendors mailing list. If additional information is
required, it can be provided upon request via the mailing list.

{{Remarks}}
The bug seems to be related to an attempt to use an invalid character in
the temporary file path. In this case : is a reserved character as per
http://msdn.microsoft.com/en-us/library/windows/desktop/aa365247%28v=vs.85%29.as
px#naming_conventions

Original issue reported on code.google.com by tortoisesvn on 19 Nov 2014 at 7:50

[GoogleCodeExporter]

This issue was closed by revision r26056.

Original comment by tortoisesvn on 19 Nov 2014 at 9:16

• Changed state: Fixed
• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

This issue was closed by revision r26071.

Original comment by tortoisesvn on 27 Nov 2014 at 9:15

• Added labels: ****
• Removed labels: ****