tbiens / icarus

SMTP&SNMP&SMB honeypot
GNU General Public License v3.0
54 stars 6 forks source link

UDP Service Attacker Detection Not Working #8

Closed Xewdy444 closed 2 years ago

Xewdy444 commented 2 years ago

The script doesn't seem to pick up attacking IPs when a UDP packet is sent to a UDP honeypot port such as one of the default UDP ports, 161.

tbiens commented 2 years ago

Hello,

Really good catch, thanks so much for reporting! The port opens but apparently in python 3.7 they changed how async udp server is coded and broke things. My code was python 3.6 style.

Looking at the newer versions of the same module:

Deprecated since version 3.8, will be removed in version 3.10: The loop parameter.

It would seem this is still unstable in future versions and syntax will be changing again in the future.

I suspect I should drop async support and go to socketserver which I use for TCP side.

Looks like I have a working solution. Just going to let it run for a little bit to ensure it's stable.

tbiens commented 2 years ago

Hello,

It ran fine overnight. I pushed the fix out to Stable. Can you give it a try please?

Xewdy444 commented 2 years ago

Yes, I can test it out.

Xewdy444 commented 2 years ago

Works great now. Thank you for fixing this.

tbiens commented 2 years ago

Thanks so much for your time in helping!