tbillenstein / jTweetsAnywhere

jTweetsAnywhere is a jQuery Twitter Widget that simplifies the integration of Twitter services into your site
http://thomasbillenstein.com/jTweetsAnywhere/
MIT License
51 stars 18 forks source link

jTweetsAnywhere on ssl enabled page #4

Closed cheeyeo closed 12 years ago

cheeyeo commented 12 years ago

Hi thomas

thank you for a great plugin - it has saved a lot of work on writing twitter anywhere code by hand!

just to point out that a lot of errors are thrown when jTweets is used on an ssl protected page

below is an example page in a production app:

https://squaremarket.com/squares/17

is there anywhere to overcome this or is it default behavior with twitter?

thank you

tbillenstein commented 12 years ago

Hi Chee,

thanks for opening this issue. As far as I know these problems are reported in Chrome browser only. They are printed on the console as warnings, but it seems that the functionality is not affected.

When jTweetsAnywhere is requesting the rate limit info from Twitter, it calls 'http://api.twitter.com/1/account/rate_limit_status.json' and does not properly consider the protocol as it does when calling other APIs. That'll be fixed.

On the other hand you include Twitter's anywhere.js script via http (). You should use https instead.

williammcrae commented 12 years ago

I found another problem with SSL enabled pages.

When the profile image is being displayed the wrong url is being used: profile_image_url needs to be replace with profile_image_url_https

PipBoy2000 commented 12 years ago

It looks like this fix is not in the minified version of 1.3.1. I am using that and experiencing the same bug. Then, when I looked to see if the url fix was in, it didn't appear to be:

...defaultRateLimitDataProvider=function(a){e.getJSON("http://api.twitter.com/1/account/rate_limit_status.json?callback=?",a)}})(jQuery); from the end of the jquery.jtweetsanywhere-1.3.1.min.js.

So I check the one in your current distribution: Same thing.

Just FYI.

PipBoy2000 commented 12 years ago

Scratch that. Looks like you haven't released it at all. Guess you are still testing. I'll wait. Thanks.

tbillenstein commented 12 years ago

@PipBoy2000 True, it's not released yet. But you can use the current version from the repo.