search

tbillington / kondo

Cleans dependencies and build artifacts from your projects.
MIT License
1.76k stars 51 forks source link

chore(ci): build with `--locked` flag #115

Open orhun opened 8 months ago

orhun commented 8 months ago 
$ cargo test -h | rg 'locked'

--locked                Require Cargo.lock is up to date

So that we can avoid #114 from happening :bear:

orhun commented 8 months ago

Ok I realized kondo-ui tests are not being run with this workflow since it is excluded from the workspace - is there any other CI checks that we can integrate --locked?

tbillington commented 8 months ago

Yep, I had to remove kondo-ui from the workspace by default because it had different build requirements and at the time I didn't consider it important enough to resolve for CI builds.

Potentially the cross build could use it?

I think the github CI in kondo could be improved, it also uses some deprecated actions that throws warnings when it runs.

orhun commented 8 months ago

Potentially the cross build could use it?

Makes sense, updated the PR!

I think the github CI in kondo could be improved, it also uses some deprecated actions that throws warnings when it runs.

I also realized that and I think I can help improving it. Do you want me to create an issue for tracking and follow up with a PR?