search

tbird20d / grabserial

Grabserial - python-based serial dump and timing program - good for embedded Linux development
GNU General Public License v2.0
195 stars 77 forks source link

Porting grabserial from Python2 to Python3 #31

Closed sinnykumari closed 4 years ago

sinnykumari commented 4 years ago

Python2 is going to retire very soon upstream on January 1, 2020 . As a result, with upcoming Fedora 31 and onward releases, Python2 packages are getting removed . Is there a plan to port grabserial from Python2 to Python3?

I tried to rebuild python-grabserial package as it is with Python3, but running it throws some error:

grabserial 
  File "/usr/bin/grabserial", line 190
    if opt in ["-d", "--device"]:
                                ^
TabError: inconsistent use of tabs and spaces in indentation
sinnykumari commented 4 years ago

Friendly ping, any update?

tbird20d commented 4 years ago

I would be happy to have grabserial work with Python3.  I already have accepted patches tofix some issues with Python3, and have done some additional work myself (particularly inthe area of unicode string handle) to have grabserial support Python2 and Python3. Any patches you would like to send, to fix issues you encounter in Python3 supportwould be most appreciated.  Please note, however, that I will not accept any patchesthat remove Python2 support.  The tool must be backward compatible with thatinterpreter. Regards, -- Tim On Thursday, August 22, 2019, 09:28:02 PM PDT, Sinny Kumari notifications@github.com wrote:

Python2 is going to retire very soon upstream on January 1, 2020 . As a result, with upcoming Fedora 31 and onward releases, Python2 packages are getting removed . Is there a plan to port grabserial from Python2 to Python3?

I tried to rebuild python-grabserial package as it is with Python3, but running it throws some error: grabserial File "/usr/bin/grabserial", line 190 if opt in ["-d", "--device"]: ^ TabError: inconsistent use of tabs and spaces in indentation

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

sinnykumari commented 4 years ago

Thanks! I will try to put a patch when I get some time

tbird20d commented 4 years ago

I re-ran my local tests, on both python2 and python3 and had no problems.Can I ask what version of grabserial you are using? Please use the one from my github repository:https://github.com/tbird20d/grabserial.git

version 1.9.9, git commit 39144da Let me know if you still see the error message with Python3. Thanks, -- Tim

I just enhanced the selftest (test.sh), and refactored the code and added inlinedirectives to make grabserial.  On Tuesday, September 3, 2019, 10:42:06 PM PDT, Sinny Kumari notifications@github.com wrote:

Thanks! I will try to put a patch when I get some time

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub, or mute the thread.

sinnykumari commented 4 years ago

I re-ran my local tests, on both python2 and python3 and had no problems.Can I ask what version of grabserial you are using? Please use the one from my github repository:https://github.com/tbird20d/grabserial.git version 1.9.9, git commit 39144da Let me know if you still see the error message with Python3. Thanks, -- Tim I just enhanced the selftest (test.sh), and refactored the code and added inlinedirectives to make grabserial.

Ah, I am using the source from v1.9.3 released version which is indeed very outdated. Didn't notice that we are tagging latest content without marking them as release. Using latest tag v1.9.9 (once available?, I see latest tag as 1.9.8) it may just build fine (will try tomorrow or over weekend)

tbird20d commented 4 years ago

Oops.  I'm not very skilled with github.  I didn't realize anyone looked at the 'releases' tab.  I've gone aheadand made 1.9.9 a release.  Thanks for the reminder. -- Tim

On Wednesday, September 4, 2019, 09:55:59 PM PDT, Sinny Kumari <notifications@github.com> wrote:

I re-ran my local tests, on both python2 and python3 and had no problems.Can I ask what version of grabserial you are using? Please use the one from my github repository:https://github.com/tbird20d/grabserial.git version 1.9.9, git commit 39144da Let me know if you still see the error message with Python3. Thanks, -- Tim I just enhanced the selftest (test.sh), and refactored the code and added inlinedirectives to make grabserial.

Ah, I am using the source from v1.9.3 released version which is indeed very outdated. Didn't notice that we are tagging latest content without marking them as release. Using latest tag v1.9.9 (once available?, I see latest tag as 1.9.8) it may just build fine (will try tomorrow or over weekend)

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub, or mute the thread.

sinnykumari commented 4 years ago

Thanks for doing 1.9.9 release! Latest update looks fine for both Python2 Fedora 30 and Python3 Fedora 31.