search

tbird20d / grabserial

Grabserial - python-based serial dump and timing program - good for embedded Linux development
GNU General Public License v2.0
195 stars 77 forks source link

Add -A option to append to output file vs. overwrite it #33

Closed AlphaSierraHotel closed 4 years ago

AlphaSierraHotel commented 4 years ago

Used in combination with the '-o ' option, '-A' or '--append' will append to the file if it already exists.

tbird20d commented 4 years ago

Looks good.  Pulled. Thanks, -- Tim ps. I'm still trying to figure out this weird github workflow.  I've done patches via e-mail for ages,and I'm still not comfortable with the way github turns a simple single patch into a branch fork and merge in the commit history.  That's on me to figure out, though. On Friday, September 6, 2019, 08:15:41 AM PDT, Allen Hubble notifications@github.com wrote:

Used in combination with the '-o ' option, '-A' or '--append' will append to the file if it already exists.

You can view, comment on, or merge this pull request online at:

  https://github.com/tbird20d/grabserial/pull/33

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

AlphaSierraHotel commented 4 years ago

Regarding the github workflow, I'm no expert in it myself but you might want to establish a 'develop' branch where development work can be done, tested and staged before a new 'release' is made. It would still be a 'fork and pull model' but would better enable collaborative development without putting the master branch (temporarily) into an unstable state. Pull requests would be made against the develop branch rather than the master branch and you would control when it was stable enough to push it to the master branch and create a new release.

Further GitHub workflow reference that may be helpful for all: