search

tbitonti / jakartaee-prototype

Other
0 stars 9 forks source link

Preserve manifest formatting: Attribute ordering and comments #45

Open volosied opened 4 years ago

volosied commented 4 years ago

When I run the transfer tool on a feature manifest, the attributes are reorganized. Rules and Manifests are attached.

rules.zip

mf.zip

I don't believe this should affect the transformation's ability to run, but I think it should output everything in the same order for consistency. And it's easier to run diff on it, too.

I upgraded this to a bug. The manifest and feature updates should keep these files in their original format / order as much as possible. That means preserving attribute order. That also means preserving comments. White space generally cannot be preserved because of manifest format requirements.

tbitonti commented 4 years ago

This is a good idea. It would require taking over the manifest read step and changing the property storage to be order preserving, making it a medium-ish sized chunk of work.