tblancher / pymazon

Automatically exported from code.google.com/p/pymazon
Other
0 stars 0 forks source link

Folders are created for track names containing slashes #25

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
For example:
http://www.amazon.de/Perception-40th-Anniversary-Box/dp/B001RYWB64/ref=dm_cd_alb
um_bb_alt

Track 14 is called
Indian Summer [(8/19/66 Vocal]

Pymazon creates folders for such tracks, see screenshot.

Original issue reported on code.google.com by ralf.ebert on 2 Aug 2010 at 3:38

Attachments:

GoogleCodeExporter commented 8 years ago
Seriously? What is Amazon thinking? Who put's "/"s in their file names?

Pymazon is acting exactly as intended and is creating intermediate directories 
for the "perceived" path. 

I really can't believe they did that...

Anyway I'll think about the best remedy for this. 

Thanks for bringing it to my attention!

Original comment by SCColbert@gmail.com on 3 Aug 2010 at 12:04

GoogleCodeExporter commented 8 years ago
Probably the original download tool takes track/album/artist name and decides 
about a suitable filename, quoting such characters. I guess there are not that 
many 'AC/DC' fans using Pymazon, otherwise this would have been discovered 
earlier. Replacing all slashes in the fields with space characters should do 
the job.

Original comment by ralf.ebert on 3 Aug 2010 at 12:15

GoogleCodeExporter commented 8 years ago
Issue 26 has been merged into this issue.

Original comment by SCColbert@gmail.com on 19 Aug 2010 at 3:11

GoogleCodeExporter commented 8 years ago
I dl:

http://www.amazon.com/dp/B0011Z10PC/ref=nosim/?tag=fatwalletcom&linkCode=as1

Green Day - American Idiot for $1.49 today.  Still have the problem.

$ ll
total 57444
-rw-rw-r-- 1 rick rick  5728666 Nov 12 09:38 01 - American Idiot.mp3
-rw-rw-r-- 1 rick rick 17598822 Nov 12 09:38 02 - Jesus Of Suburbia.mp3
drwxrwxr-x 2 rick rick     4096 Nov 12 09:38 03 - Holiday
drwxrwxr-x 2 rick rick     4096 Nov 12 09:38 04 - Are We The Waiting
drwxrwxr-x 2 rick rick     4096 Nov 12 09:38 05 - Give Me Novacaine
drwxrwxr-x 2 rick rick     4096 Nov 12 09:38 06 - Extraordinary Girl
-rw-rw-r-- 1 rick rick  9186166 Nov 12 09:38 07 - Wake Me Up When September 
Ends.mp3
-rw-rw-r-- 1 rick rick 17918129 Nov 12 09:39 08 - Homecoming.mp3
-rw-rw-r-- 1 rick rick  8275813 Nov 12 09:39 09 - Whatsername.mp3

Original comment by rickr...@gmail.com on 12 Nov 2010 at 7:26

GoogleCodeExporter commented 8 years ago
this will  be fixed for the 1.0 release. just need to find the time...

Original comment by SCColbert@gmail.com on 12 Nov 2010 at 8:30

GoogleCodeExporter commented 8 years ago
As a small update to this issue:
I've just started using Pymazon on my Nokia N900 with the latest firmware (so 
QT4.7). By chance, the album I decided to download had a couple of tracks with 
slashes in the filenames. Unfortunately, I think the permissions set on the 
music folder precluded the creation of folders, so the download of the album 
hung once the first track with a slash had reached 100%.

Later on, I used the same .AMZ file to download the album on my (Windows) PC, 
and noticed that the Amazon downloader replaced the slashes with ' - ' (ie. 
Space dash space) in its "to be downloaded" list. The track title in the 
metadata still included the slashes, so it's obviously a bit of logic Amazon 
have had to include in the downloader program to deal with this issue.

Original comment by a...@blundells.org on 23 Nov 2010 at 9:07

GoogleCodeExporter commented 8 years ago
$3.99: Bride Of The Noisemakers (Amazon MP3 Exclusive Version) [+digital 
booklet]

http://www.amazon.com/Noisemakers-Exclusive-Version-digital-booklet/dp/B004WTPB4
0/ref=amb_link_356152002_3?pf_rd_m=ATVPDKIKX0DER&pf_rd_s=browse&pf_rd_r=0YAR2D26
MDG5A48FYD98&pf_rd_t=101&pf_rd_p=1295600782&pf_rd_i=163856011

Same thing repeated for 5 songs !

Original comment by rickr...@gmail.com on 2 May 2011 at 7:35

GoogleCodeExporter commented 8 years ago
Patch...

Original comment by rickr...@gmail.com on 2 May 2011 at 10:45

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks. I'll try to make a bug-fix release soon.

Original comment by SCColbert@gmail.com on 2 May 2011 at 10:48

GoogleCodeExporter commented 8 years ago
Issue 40 has been merged into this issue.

Original comment by SCColbert@gmail.com on 22 May 2011 at 4:53

GoogleCodeExporter commented 8 years ago
As long as I took the time to make it, I would like to request that you 
consider the patch I submitted in Issue 40 in addition to Rick's. I just wanted 
to make sure you didn't miss it with the ticket merge. I feel like it's more 
comprehensive than Rick's change, but of course no hard feelings of course if 
you prefer Rick's. Thanks.

Original comment by orbliv...@gmail.com on 4 Jun 2011 at 5:48

GoogleCodeExporter commented 8 years ago
I'll consider all patches when I make a new release.

Original comment by SCColbert@gmail.com on 4 Jun 2011 at 3:37

GoogleCodeExporter commented 8 years ago
I get the same Error not only with the song title also with the album name. A 
good example for this error is the album 180/365 from OK Go because all the 
song titles include a date at the end with a couple of slashes : 
http://www.amazon.com/180-365-OK-Go/dp/B004X6J2YM/ref=sr_1_1?ie=UTF8&qid=1321548
826&sr=8-1

Original comment by Kai.Behr...@gmail.com on 17 Nov 2011 at 4:56

GoogleCodeExporter commented 8 years ago
Attached is another patch for this. The "patch01" in this issue only addresses 
track titles, and is unix-specific. The patch in Issue 40 prevents you from 
making a template with intermediate directories in it, like 
'${artist}/${album}/', if I'm reading it correctly.

Original comment by adea...@gmail.com on 24 Nov 2011 at 5:14

Attachments:

GoogleCodeExporter commented 8 years ago
I made a patch a while back to tide me over until somebody found time to make a 
real patch. I just updated it for 0.9.1 so I might as well upload it here even 
though it is kinda ugly. I decided to turn slash, colon (for Microsoftish file 
systems) and backslash (just because) into underscore, and to filter all fields 
except track and disc numbers. 

Original comment by catmat...@gmail.com on 16 Jan 2012 at 6:36

Attachments: