search

tblancher / pymazon

Automatically exported from code.google.com/p/pymazon
Other
0 stars 0 forks source link

${album_artist} tag results in a folder and/or a file with literal "${album_artist}" instead of tag content. #43

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Use the ${album_artist} tag for file naming.

What is the expected output? What do you see instead?
When downloading a multi-artist album or sampler the ${album_artist} tag should 
show something like "Various Artists" or "2011 Sampler". I see a literal 
"${album_artist}" which is not replaced with the tag info.

What version of the product are you using? On what operating system?
0.9.1 on Debian 6.0.3

Original issue reported on code.google.com by mobiledi...@gmail.com on 3 Dec 2011 at 8:24

GoogleCodeExporter commented 8 years ago 
There's a typo in the info panel of the settings dialog. The tag you want is 
${albumartist}.

Original comment by SCColbert@gmail.com on 3 Dec 2011 at 9:00

GoogleCodeExporter commented 8 years ago 
I don't know why I didn't try it that way. I tried ${artist_album} but didn't 
try leaving out the underscore.

If Microsoft responded to bug reports so quickly I would still be using Windows.
Thank you!

Original comment by mobiledi...@gmail.com on 4 Dec 2011 at 4:11

GoogleCodeExporter commented 8 years ago 
I liked the underscore, so I changed the code itself to recognize album_artist 
in my branch. 

I'll be adding code to check for unrecognized options as well so that this 
won't be an issue in the future.

Original comment by emarshal...@gmail.com on 4 Feb 2012 at 9:42

GoogleCodeExporter commented 8 years ago 
Digging through code before I thought to look at issues, I found these are the 
locations where there could be confusion between "albumartist" and 
"album_artist".  Since I had already figured out that I should have been using 
${albumartist} I was focusing on locations where the help text needed to be 
updated rather than making code within logic fit the help text...
gtk/_ui.glade, line 759
qt/_nameformatdialog.py, lines 75, 93
qt/_nameformatdialog.ui, lines 51, 69

In core/options.py the help text only has:
${tracknum}
${title}
${artist}
${album}
It is missing ${albumartist}, ${genre}, and ${discnum}.  Are these valid for (I 
assume) command line use and should they be added to the text?

I also found that core/parser.py does reference album_artist at lines 134, 139 
and 143.  Not sure how this fits (not familiar with Python and haven't tried to 
dig very deep) as the other locations that use album_artist are just incorrect 
help text.

Original comment by craig....@gmail.com on 19 Feb 2014 at 8:10