Open GoogleCodeExporter opened 8 years ago
There's a typo in the info panel of the settings dialog. The tag you want is
${albumartist}.
Original comment by SCColbert@gmail.com
on 3 Dec 2011 at 9:00
I don't know why I didn't try it that way. I tried ${artist_album} but didn't
try leaving out the underscore.
If Microsoft responded to bug reports so quickly I would still be using Windows.
Thank you!
Original comment by mobiledi...@gmail.com
on 4 Dec 2011 at 4:11
I liked the underscore, so I changed the code itself to recognize album_artist
in my branch.
I'll be adding code to check for unrecognized options as well so that this
won't be an issue in the future.
Original comment by emarshal...@gmail.com
on 4 Feb 2012 at 9:42
Digging through code before I thought to look at issues, I found these are the
locations where there could be confusion between "albumartist" and
"album_artist". Since I had already figured out that I should have been using
${albumartist} I was focusing on locations where the help text needed to be
updated rather than making code within logic fit the help text...
gtk/_ui.glade, line 759
qt/_nameformatdialog.py, lines 75, 93
qt/_nameformatdialog.ui, lines 51, 69
In core/options.py the help text only has:
${tracknum}
${title}
${artist}
${album}
It is missing ${albumartist}, ${genre}, and ${discnum}. Are these valid for (I
assume) command line use and should they be added to the text?
I also found that core/parser.py does reference album_artist at lines 134, 139
and 143. Not sure how this fits (not familiar with Python and haven't tried to
dig very deep) as the other locations that use album_artist are just incorrect
help text.
Original comment by craig....@gmail.com
on 19 Feb 2014 at 8:10
Original issue reported on code.google.com by
mobiledi...@gmail.com
on 3 Dec 2011 at 8:24