Allow for options with empty string value

tbleckert / react-select-search

⚡️ Lightweight select component for React

https://react-select-search.com

MIT License

676 stars 149 forks source link

Allow for options with empty string value #111

Closed joeyparis closed 3 years ago

joeyparis commented 3 years ago

This pull request adds support for selecting an input that has an empty string value. This is useful for "clearing a selection" or unassigning a value.

I think I ran all the proper tests and build scripts before committing, but let me know if I missed anything!

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tbleckert/react-select-search/hsgzi0iv4
✅ Preview: https://react-select-s-git-fork-joeyparis-allow-empty-string-1b3eb6.tbleckert.vercel.app

joeyparis commented 3 years ago

@tbleckert I'm confused, did this change make it into the next version?

tbleckert commented 3 years ago

@joeyparis Sorry for the confusion, didn't have time to write a comment yesterday. Had to close this one since it's not compatible with the v3 version unfortunately. Appreciate the work. If you think this still applies in v3 I can reopen it and we can discuss it more.