tbleckert / react-select-search

⚡️ Lightweight select component for React
https://react-select-search.com
MIT License
676 stars 149 forks source link

mismatch type for getOptions (async) param on v2.0.6 #117

Closed andreymoser closed 3 years ago

andreymoser commented 3 years ago

Hey @tbleckert 😀 !

I have reading the docs, storybook and code and I noticed that getOptions type on v2.0.6 seems to not match each other, as per I have checked it should be getOptions?: (query:string) => Promise<SelectSearchOption[]> instead of getOptions?: (query:string) => Promise<SelectedOption>.

I am going to create a PR soon with this suggestion in order to help, please let me know if there is something else there. 🚀

tbleckert commented 3 years ago

Good catch! I merged the PR and was included in the latest published patch 2.0.7