Closed kylejb closed 3 years ago
vercel[bot]
commented
3 years ago This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/tbleckert/react-select-search/p0wf8991w
✅ Preview: https://react-select-search-p0wf8991w.vercel.app
tbleckert
commented
3 years ago Sorry to have to close this, really appreciate the work. The v3 release I worked on simultaneously already moved to React 17 and removed enzyme. Otherwise great work.
kylejb
commented
3 years ago Thanks for the update. I appreciate your feedback.
RE: React 17 support #135
Summary of Changes:
npm updateand rannpm audit fixto resolve to low vulnerabilities.enzyme-adapter-react-16and replaced it with@wojtekmaj/enzyme-adapter-react-17(this is a temporary solution and must be replaced once the official enzyme adapter is released for React 17).This is my first contribution! Let me know if there is anything that I can do to improve.
Detailed Report:
WARNING: Since
__tests__relies onenzyme-adapter-react-16, I replaced the package with @wojtekmaj/enzyme-adapter-react-17 to ensure tests continue to work with React 17. This package is very similar to the previous version; it only incorporates changes to the adapter so that the package remains compatible with React 17.The maintainer of this package intends to depreciate it once enzyme releases their official adapter for React 17. This should be tracked and replaced as soon as possible.
After updating package dependencies, I ran
npm test. All tests passed:I also ran
npm audit fixto resolve potential issues with two packages:ini(updated version to resolve Prototype Pollution issue)node-fetch(updated version to resolve Denial of Service issue)FYI -
I want to flag three warnings that arose while running
npm test:Although it may be correctable by updating syntax, I wanted to bring this to your intention in case this points to potentially larger problems.