tbleckert / react-select-search

⚡️ Lightweight select component for React

https://react-select-search.com

MIT License

675 stars 149 forks source link

improve type definitions #162

Open manvydasu opened 3 years ago

manvydasu commented 3 years ago

158

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tbleckert/react-select-search/ge3ozrqot
✅ Preview: https://react-select-search-git-fork-manvydasu-master.tbleckert.vercel.app

ramonsnir commented 2 years ago

@tbleckert Hi, this wrong type is blocking us from using this library with TypeScript. Can you take a look and review it or merge it?

I see there's a small merge conflict, but it's very minor. If you need help with it because you're busy, I'll gladly help.

Thanks, we love this library (although using it with non-TS JS now :smile: )!

AndrejGajdos commented 2 years ago

@tbleckert any update on this?

potatosenior commented 2 years ago

Why is this still open?

and-poulsen commented 1 year ago

@tbleckert, this would be lovely to merge in 😌