solved bug related to using multiple in Async: (fixed eslint errors)

tbleckert / react-select-search

⚡️ Lightweight select component for React

https://react-select-search.com

MIT License

676 stars 147 forks source link

solved bug related to using multiple in Async: (fixed eslint errors) #92

Closed alihamuh closed 3 years ago

alihamuh commented 4 years ago

I was having an issue using multiple with getOption/Async etc. So I solved the bug.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tbleckert/react-select-search/2423aoiko ✅ Preview: https://react-select-search-git-fork-alihamuh-master.tbleckert.vercel.app

tbleckert commented 4 years ago

@alihamuh Thanks, looks much better now! Two things:

Remove the code instead of just commenting it out. Because of version control we can revert if needed anyways.
This breaks the default behavior (close on select), see https://react-select-search-git-fork-alihamuh-master.tbleckert.vercel.app/?path=/story/multiple-select--on-focus

alihamuh commented 4 years ago

Hi. I solved the issue related to focus. It was just some re-sequencing of code in the callback. No code removed or added.

tbleckert commented 3 years ago

Hi again @alihamuh . Great work, sorry for the delay. Your fixes came during my vacation so didn't see it until recently 😔. Anyway, it has been merged now!