massage file handling - Githubissues

tbnobody / OpenDTU

Software for ESP32 to talk to Hoymiles/TSUN/Solenso Inverters

GNU General Public License v2.0

1.69k stars 471 forks source link

massage file handling #2115

Open mpw96 opened 2 days ago

mpw96 commented 2 days ago

Just improving file handling:

Close the file to read from immediately after reading,
set encoding in open methods.

This actually fixes nothing, but improves code style.

tbnobody commented 2 days ago

Please provide a proper description of this PR. It currently works as expected. Why do you want to change things? Please also correct spelling mistakes.

mpw96 commented 2 days ago

Please also correct spelling mistakes.

I wanted to write "massage", because I'm massaging the code... ;-)

mpw96 commented 13 hours ago

@tbnobody If you don't like this change (and you are right that it fixes nothing) you can as well close this pull request. Thank you!