search

tbo47 / dagre-es

The dagrejs library exported as ES modules.
Other
32 stars 14 forks source link

Typescript migration #28

Closed tbo47 closed 11 months ago

tbo47 commented 11 months ago

Moving to typescript will allow better types and better integration with typescript framework.

@aloisklink @sidharthv96 @remcohaszing Do you mind having a look?

aloisklink commented 11 months ago

Also, we can borrow some types from https://www.npmjs.com/package/@types/dagre, https://www.npmjs.com/package/@types/dagre-d3, and https://www.npmjs.com/package/@types/graphlib if we ever want to improve our types. It's all under the MIT license, so we just need to a copyright message and we can legally use it.

tbo47 commented 11 months ago

Also, we can borrow some types from https://www.npmjs.com/package/@types/dagre, https://www.npmjs.com/package/@types/dagre-d3, and https://www.npmjs.com/package/@types/graphlib if we ever want to improve our types. It's all under the MIT license, so we just need to a copyright message and we can legally use it.

oh nice, I will definitely do that!

tbo47 commented 11 months ago

Also, we can borrow some types from https://www.npmjs.com/package/@types/dagre, https://www.npmjs.com/package/@types/dagre-d3, and https://www.npmjs.com/package/@types/graphlib if we ever want to improve our types. It's all under the MIT license, so we just need to a copyright message and we can legally use it.

I just tried to add types but it breaks the unit tests in a way which make me doubt the types in https://www.npmjs.com/package/@types/ are 100% correct. I'm not sure what to do here. Probably work for a later PR...