Revert "remove some lodash" to fix regressions

tbo47 / dagre-es

The dagrejs library exported as ES modules.

Other

32 stars 14 forks source link

Revert "remove some lodash" to fix regressions #42

Closed aloisklink closed 2 weeks ago

aloisklink commented 2 weeks ago

This reverts commit 58b441f0ef47b03f230f4549e5413d0e1446c22d from PR #34.

I did a git bisect on #34, and I found that this commit was causing unintended visual changes (see https://github.com/tbo47/dagre-es/pull/40#issuecomment-2373818978), and we're not 100% sure why.

Unfortunately, since that commit is so large, it's hard to tell exactly which change causes the regression, so for now, we'll just revert the entire commit. Later, we can try adding it back again, piece-by-piece (ideally with a unit test!).

Closes #41 (alternate PR that fixes the same issue).

tbo47 commented 2 weeks ago

I double checked all the changes from last 7.0.10 and everything looks fine.

Can I release a 7.0.11? Or do you need more time for testing? @aloisklink

This can be the release note:

replace lodash _.has by Object.prototype.hasOwnProperty.call
add unit test from legacy project dagre-3d
code formatting with prettier
update dependency (notably vitest from 0.2 to 2.1)

Replacing _.has allows a better types generation from typescript.

aloisklink commented 2 weeks ago

Can I release a 7.0.11?

Sounds good to me!

I've already tested it with mermaid-js/mermaid and I didn't spot any issues! And considering the changes are so small now, I doubt there would be any issues for anybody else either.

tbo47 commented 2 weeks ago

https://github.com/tbo47/dagre-es/releases/tag/7.0.11