search

tbo47 / dagre-es

The dagrejs library exported as ES modules.
Other
33 stars 14 forks source link

[Safari] Link arrows are not displayed #46

Open marcos-iov42 opened 1 month ago

marcos-iov42 commented 1 month ago

On Safari, the link arrows are not displayed.

tbo47 commented 1 month ago

I can see that there is no arrows on Safari with this example https://jsfiddle.net/tbo47/fm9ovqeb/ But it works on Chrome and Firefox

marcos-iov42 commented 1 month ago

Yes, exactly. Do you think it can be fixed for Safari? Thank you

tbo47 commented 1 month ago

I probably won't have the time to look at it any time soon.

If you want to investigate, I suggest you compare what you see in Chrome and Safari here: https://tbo47.github.io/dagre-d3-esm_example1/

image

tbo47 commented 1 month ago

If you are not qualify to fix the bug, I'm sure that offering a $5000 reward for anyone fixing the bug will help lol

aloisklink commented 1 month ago

I'm sure that offering a $5000 reward for anyone fixing the bug will help lol

:laughing: I've once accidentally fixed a bug that had a $10k reward (in that I fixed the bug because it annoyed me, before realizing there was a reward).

@marcos-iov42, it might also be worth checking if this bug affects the upstream dagre-d3 project: https://github.com/dagrejs/dagre-d3 That project has much more popularity, and so if the bug is in there, it's much more likely for somebody to spot it and fix it!

tbo47 commented 1 month ago

It's such a weird bug. I can stop the debugger at https://github.com/tbo47/tbo47.github.io/blob/main/dagre-d3-es.7.0.11.js#L2537 and see that Safari is building the markers. It sometimes renders too: image

Safari has issues with rendering svg marker it seems like.