search

tbodt / deoplete-tabnine

Deoplete source for TabNine
256 stars 17 forks source link

Opening parens are not being closed automatically #26

Closed dkvasnicka closed 5 years ago

dkvasnicka commented 5 years ago

TabNine introduced a feature when it closes parentheses it opens in a completion suggestion. However this plugin does not honor that and no parens are being closed

See https://github.com/zxqfl/TabNine/commit/bca744fa0ccbba6e60ae092cf4a705e636e32655#diff-04c6e90faac2675aa89e2176d2eec7d8R33

Shougo commented 5 years ago

Please read this.

https://github.com/zxqfl/TabNine/issues/106

It is not deoplete-tabnine's fault. Other tabnine's clients cannot support the feature.

tbodt commented 5 years ago

Apparently it is possible based on the response to zxqfl/TabNine#106.

Shougo commented 5 years ago

I get it. deoplete support is needed for the feature.

Shougo commented 5 years ago

Please wait. I will add the support.

Shougo commented 5 years ago

@dkvasnicka Please test #31.

dkvasnicka commented 5 years ago

I've updated Deoplete and switched to the shougo/suffix branch for this plugin but I see no change. Whenever the completion is like object.method( or object.method(" nothing gets closed when I press enter to select the completion option (note that you need to be able to close multiple nested pairs, like a paren and a quote -- but not even simple paren closing works). Anything I should check out?

I would much rather see TabNine itself to completely remove this partial completion pseudofeature, I don't even understand why they are doing this. But seems like they don't perceive this as a problem...

dkvasnicka commented 5 years ago

Ah, sorry, works! I switched to the fix branch but then I did Plug update to get the new Deoplete and it silently switched me back to master. Works like a charm!