tbodt / v8py

Write Python APIs, then call them from JavaScript using the V8 engine.
GNU Lesser General Public License v3.0
440 stars 28 forks source link

add linux specific header and silence errors #1

Closed justinkirby closed 7 years ago

justinkirby commented 7 years ago

-Werror flag was causing the build to fail. Primarily due to new warnings in gcc 5.4.0. Only reliable way to disable it was the gypflags.

Add arpa/inet.h for htos if on linux. Other platforms may need it.

tbodt commented 7 years ago

Thanks! (Build failures on python 2 are my fault.)

If I may ask, what are you using V8Py for?

justinkirby commented 7 years ago

We have a lot of javascript code and a lot of python code, with a new feature that requires they play nice.

I tried this today and it seems to work and do what is needed.

I was even able to build the wheel and distribute it to our test servers running py3.6

Thanks for creating this project.

tbodt commented 7 years ago

😊