tbodt / v8py

Write Python APIs, then call them from JavaScript using the V8 engine.
GNU Lesser General Public License v3.0
440 stars 28 forks source link

Python Wheels #21

Open armudgal opened 6 years ago

armudgal commented 6 years ago

Hi, I am working on wheels for this project and was writing a travis script for the same. I am currently targeting linux with PyPA's manylinux and is using their docker image. I am facing some issues in the travis build and would like to hear your advice. My fork: https://github.com/kira0204/v8py/tree/travis-wheels Also, I am working with @buffer on this.

tbodt commented 6 years ago
  v8/out/native/obj.target/src/libv8_libplatform.a: could not read symbols: Malformed archive

I think this is because the version of v8 that was built outside Docker and cached by Travis is not compatible with the manylinux image. Try clearing the cache?

tbodt commented 6 years ago

I think the button to do that is under the "More Options" menu.

armudgal commented 6 years ago

Sure thanks, will do so

armudgal commented 6 years ago

Also, the built of v8 is done with the command python2. The problem I am facing right now is that the CentOS5 docker image has Python2.4 as python2, and depot_tools need python2.7or higher to fetch --force v8. I am not sure what would be the best workaround here since we have different platforms over here.

One solution: Instead of running the fetch --force v8 command, what we can do is run the command python2.7 depot_tools/fetch.py --force v8. Adding python2.7 to the PATH in the docker image would be a simple step then.

armudgal commented 6 years ago

Update: I had to include python2.7 in the path so that python2 resolved to python2.7.4 in this case. The other issue being raised is here, the tar version in CentOS 5 is 1.15.1 and updating it is a very very weird option. Never thought building v8 only would be such a PITA in CentOS 5.

tbodt commented 6 years ago

Does CentOS 5 have a newer version of tar in the package repos? If not, you may end up having to compile it from source...

armudgal commented 6 years ago

Hi, sorry for the late reply, no CentOS5 doesn't have a new version of TAR and compiling it from source is not the option because CentOS5 doesn't support it. I put a pause on this because PyPA is updating the manylinux repo to run on a newer version on CentOS because of CentOS 5 reaching EOL a year back (https://github.com/pypa/manylinux/issues/179).

The best option right now would be to wait for them to do it (which might take 3-4 weeks more) and then work on the new manylinux2010.

desertkun commented 4 years ago

@armudgal just wondering who the manylinux thing go

armudgal commented 4 years ago

@desertkun The manylinux2010 has been released, more info can be found here.

I didn't get much time to follow up on that though

scottp-dpaw commented 4 years ago

See https://github.com/tbodt/v8py/pull/39