tbodt / v8py

Write Python APIs, then call them from JavaScript using the V8 engine.

GNU Lesser General Public License v3.0

440 stars 28 forks source link

v8 to perform a clean checkout #27

Closed wimoMisterX closed 6 years ago

wimoMisterX commented 6 years ago

5 images files committed on 18th June 2018 with no proper file line endings caused the files to be modified when the v8 repo was cloned on Ubuntu machines. This in turn caused the checkout to branch-heads/5.9 to fail. Fixes #26

tbodt commented 6 years ago

I think it would be simpler to use git checkout -f, instead of mucking around with gitattributes and things.

wimoMisterX commented 6 years ago

@tbodt that worked! I'll update my pull request

codecov-io commented 6 years ago

Codecov Report

Merging #27 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   80.73%   80.73%           
=======================================
  Files          16       16           
  Lines        1339     1339           
=======================================
  Hits         1081     1081           
  Misses        258      258

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 838a5de...62eac8d. Read the comment docs.

wimoMisterX commented 6 years ago

@tbodt are you able to merge this and do a new release? I can't build my project at the moment!

Thanks!

tbodt commented 6 years ago

I will merge now, and I can do a release tomorrow.

wimoMisterX commented 6 years ago

Thank you for reviewing so promptly :)