tbodt / v8py

Write Python APIs, then call them from JavaScript using the V8 engine.
GNU Lesser General Public License v3.0
440 stars 28 forks source link

Windows support #29

Closed desertkun closed 5 years ago

desertkun commented 6 years ago
codecov-io commented 6 years ago

Codecov Report

Merging #29 into master will increase coverage by 0.27%. The diff coverage is 97.05%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #29      +/-   ##
========================================
+ Coverage   80.73%    81%   +0.27%     
========================================
  Files          16     16              
  Lines        1339   1353      +14     
========================================
+ Hits         1081   1096      +15     
+ Misses        258    257       -1
Impacted Files Coverage Δ
v8py/pyfunction.cpp 100% <ø> (ø) :arrow_up:
v8py/jsobject.cpp 89.43% <ø> (ø) :arrow_up:
v8py/greenstack.cpp 40% <ø> (ø) :arrow_up:
v8py/pyclass.cpp 95.67% <ø> (ø) :arrow_up:
v8py/script.cpp 90.1% <ø> (ø) :arrow_up:
v8py/context.cpp 88.1% <ø> (ø) :arrow_up:
v8py/exception.cpp 93.18% <ø> (ø) :arrow_up:
v8py/debugger.cpp 10% <ø> (ø) :arrow_up:
v8py/jsfunction.cpp 96.96% <100%> (+0.41%) :arrow_up:
v8py/convert.cpp 85% <100%> (+1.12%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4222ed8...ab52801. Read the comment docs.

desertkun commented 6 years ago

The last build went okay, I don’t know why its showing up as failed. Do you know how to retrigger a build?

tbodt commented 6 years ago

It's complaining because the code coverage went down, which is because of the extra if statements added to choose between VLAs and heap allocation on not-windows. It's probably OK to merge, though you could add test cases for longer strings and larger number of arguments.

desertkun commented 6 years ago

It's all set now.

desertkun commented 6 years ago

Bam!