tbodt / v8py

Write Python APIs, then call them from JavaScript using the V8 engine.
GNU Lesser General Public License v3.0
443 stars 29 forks source link

Fix binary wheel build step #39

Closed moralrecordings closed 4 years ago

moralrecordings commented 4 years ago

PyPI expects Linux binaries to be built to the manylinux specification. The build toolchain for V8 uses a new-ish glibc, so this process produces manylinux2014-compatible packages.

I've tested the cibuildwheel build process, but the changes to the Travis build script are speculative based on the manual process I used. With luck opening a PR will fire off a proper test.

tbodt commented 4 years ago

Please mark this as ready for review when it's done

scottp-dpaw commented 4 years ago

Notes:

tbodt commented 4 years ago

Thanks for the PR. It'll be good to finally have wheels, 3 years later. There are a few areas of future work I've noted, otherwise looks good to me (as long as it actually works).

If you don't mind me asking, what are you using v8py for?

armudgal commented 4 years ago

This is great. Thanks for the PR