search

tbodt / v8py

Write Python APIs, then call them from JavaScript using the V8 engine.
GNU Lesser General Public License v3.0
440 stars 28 forks source link

Expose JSObject and JSFunction #6

Closed buffer closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #6 into master will increase coverage by 0.44%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   67.34%   67.79%   +0.44%     
==========================================
  Files          16       16              
  Lines        1176     1180       +4     
  Branches      184      184              
==========================================
+ Hits          792      800       +8     
+ Misses        261      257       -4     
  Partials      123      123
Impacted Files Coverage Δ
v8py/v8py.cpp 67.9% <100%> (+1.66%) :arrow_up:
v8py/jsobject.cpp 74.15% <0%> (+1.12%) :arrow_up:
v8py/jsfunction.cpp 44.44% <0%> (+11.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d02542...068a2d0. Read the comment docs.

buffer commented 7 years ago

The new patch takes care of the details you pointed out. Thanks, Angelo

tbodt commented 7 years ago

Should I push this to PyPI now, or wait for patches for triggering GC or setting the stack limit?

buffer commented 7 years ago

Hope I will be able to work on that stuff in the next hours. But if you are already planning a new release please do.