search

tboegi / GpsMaster

https://wiki.openstreetmap.org/wiki/GpsMaster
GNU General Public License v2.0
48 stars 7 forks source link

Track filter panel improvement #11

Closed nielstiben closed 3 years ago

nielstiben commented 3 years ago

@rfuegen I implemented a dynamic track filter panel. It is visible when >=5 routes/tracks are loaded in the application and hidden when there are fewer than 5. The threshold can be set in the config, and the default is 5 for now.

In addition: Fix NullPointerException for filtering tracks/route without a name. Fix NullPointerException when no tracks/routes are loaded. Fix bug where filter does not work when more than 1 GPX file is loaded.

tboegi commented 3 years ago

Thanks for the PR - I look into it as soon as possible.

tboegi commented 3 years ago

@rfuegen : The PR merges cleanly - no objections from my side. Do you have any objections ?

rfuegen commented 3 years ago

hi niels, if I'm not mistaken, updateTrackFilterPanelVisibility() should also be called when handling the PCE_NEWGPX event. otherwise, no objections. thanks.

rfuegen commented 3 years ago

one more: please set default config value to 10.

tboegi commented 3 years ago

I merged it manually and pushed the result to the dev branch