search

tbohne / vehicle_diag_smach

Neuro-symbolic anomaly detection and complex fault diagnosis exemplified in the automotive domain.
MIT License
4 stars 1 forks source link

Using version tags in python requirements #18

Closed T-Thurow closed 12 months ago

T-Thurow commented 12 months ago

The requirements.txt currently references the upstream version of obd_ontology and oscillogram_classification which are prone to change.

It would be better to reference specific version tags or commit hashes to keep older commits build clean in case there are API changes for obd_ontology oroscillogram_classification.

tbohne commented 12 months ago

I agree, did that. However, at the moment it doesn't make a difference as the latest versions are the ones that are supposed to be used.

T-Thurow commented 12 months ago

I see. We are currently trying to maintain a stable branch of our code which should always be build clean. The vehicle_diag_smach was frozen to commit 4c2b043ef336a58471f652c8199efefa3aef84e6 which was a working state at merge time but it started failing because of the config module bug in oscillogram_classification and since you fixed that it crashed because local_kb was removed from OntologyInstanceGenerator in obd_ontology which the frozen code still had. For the sake of stability a changing version tag seems like a good way to preserve a working state. An package index like pypi would also be good. Have you considered publishing to a package index in the long run?

tbohne commented 12 months ago

This state of vehicle_diag_smach is no longer compatible with the latest versions of the other repos. As long as there are no tags, it should work best if you always use the latest version. However, I am currently working on a first clean, compatible and tagged state of all repos. Only vehicle_diag_smach is missing, the others are already tagged. When I'm done with this (on vacation next week), you can always use a stable / compatible state of the repos. I didn't do that before because there were still some API changes planned, and that shouldn't be the case in the future (at least very rarely). As said, for now it should work if you just use the latest version of vehicle_diag_smach.

Regarding PyPi, yes, we can do that in the long run, but only when we have a compatible and clean first version, which should be the case very soon.