Termination criterion in diagnostic loop - Githubissues

tbohne / vehicle_diag_smach

Neuro-symbolic anomaly detection and complex fault diagnosis exemplified in the automotive domain.

MIT License

4 stars 2 forks source link

Termination criterion in diagnostic loop #7

Open tbohne opened 1 year ago

tbohne commented 1 year ago

the smach ends with the first detected anomaly that has been isolated, it doesn't continue with potential remaining DTCs - should it?
it is conceivable that the remaining DTCs should also be examined, even if anomalies have already been detected

tbohne commented 1 year ago

tbohne commented 1 year ago

requirements:
- 1.) another transition from ISOLATE_PROBLEM_CHECK_EFFECTIVE_RADIUS to SELECT_BEST_UNUSED_DTC_INSTANCE, e.g., named isolated_problem_and_remaining_DTCs
- 2.) save the already found fault paths in some session file
- 3.) handle cases in which a following DTC leads to no further anomalies
- in this case, currently there would be NO_PROBLEM_DETECTED_CHECK_SENSOR, then sensor_works, and then PROVIDE_INITIAL_HYPOTHESIS_AND_LOG_CONTEXT, which doesn't make sense
- there should be another transition, additional to sensor_works, which is sensor_works_and_already_found_fault_path, leading to PROVIDE_DIAG_AND_SHOW_TRACE
- 4.) in PROVIDE_DIAG_AND_SHOW_TRACE, we need to seperate all the new cases