tbointeractive / TBODeveloperOverlay

A collection of developer tools for debugging iOS Apps
MIT License
5 stars 2 forks source link

Feature/#3 kv detail view controller for types #17

Closed bernhard-eiling closed 8 years ago

brototyp commented 8 years ago

Thanks for your pull request. There is one point of the concept I would like to talk about. That is the process of registering VC-Classes for certain value types. I am not sure if this is the best way. Downsides I see this was:

How about something like this:

bernhard-eiling commented 8 years ago

I like the introduction of the protocol describing our DetailViewControllers. This also serves the readability of our API for the KVDebugger.

Also I like the emphasis of an optional saveBlock and descriptionString by removing the setting of those properties from initialization to their setters.

Overall nice additions and code style refinements!