Closed brototyp closed 7 years ago
One thing:
The question is if -logMessageRegularExpression: matches including a newline or without. The current implementation expects it to match including the new line. That is the reason why I append a newline to the log in TBODeveloperOverlayLoggerCocoaLumberjackDatasource:90. That is definitely not a beautiful solution.
An alternative would be to expect that there are never two log messages in one line. Thus the regex doesn't include the newline. Then we could join all matches via a newline in TBODeveloperOverlayLoggerCocoaLumberjackDatasource-filteredLog:
Is there a case where one would want to have multiple log-messages in a single line?
:white_check_mark: Well done. | |
---|---|
:white_check_mark: |
1 Warning | |
---|---|
:warning: | PR is classed as Work in Progress |
Generated by :no_entry_sign: danger
Ok, I went with the logMessageRegularExpression to not contain the newline.
Before this, when one selected the "Error"-Filter or such, it would only match the first line of this log message. Now it will select the whole message. The same is true for searching.