search

tbointeractive / bytes

bytes is a set of Swift tools to cover many all-day tasks in iOS development.
MIT License
7 stars 1 forks source link

Add BundleIdentifier to Application struct #37

Closed thorstenstark closed 2 years ago

thorstenstark commented 5 years ago

We should add the bundle identifier to the Application struct. Additionally I would suggest to modify the descriptions of the properties to include the used Key to retrieve a value from the bundle. That would prevent some accidental misuses.

brototyp commented 5 years ago

What do you mean by bundle identifier? The CFBundleName? Or something different?

I like the idea to adding some details to the documentation!

thorstenstark commented 5 years ago

No, I mean CFBundleIdentifier ;)

brototyp commented 5 years ago

Ah yeah, got it. Just out of curiosity: What would be the use case to access this via the Application?

thorstenstark commented 5 years ago

Do you think that would not fit here? I would say it has the same use case as Application.name or Application.displayName.

brototyp commented 5 years ago

Do you think that would not fit here? I would say it has the same use case as Application.name or Application.displayName.

No, don't get me wrong. I think it fits perfectly. I am just curious how you thought about adding it and if you possibly already have a use case in mind.

thorstenstark commented 5 years ago

I see. We needed to access the bundle identifier lately and a collegue misused Application.name for it because the documentation looked like it would return the bundle identifier (but didn't).