Infinite Re-renders inside Semantic-UI Modal

tbolis / react-sketch

Sketch Tool for React-based applications, backed up by FabricJS

http://tbolis.github.io/showcase/react-sketch/

MIT License

683 stars 230 forks source link

Infinite Re-renders inside Semantic-UI Modal #86

Closed larrysharette closed 4 years ago

larrysharette commented 5 years ago

I have a project where we want to be able to open a Modal with the sketchfield and I'm running into an issue where trying to open the Modal causes the sketchfield to be infinitely re-rendered. I've tried just a basic modal like this: `

` but no luck it just re-renders endlessly.

larrysharette commented 5 years ago

I figured out what is causing the issue. Its because I don't have a width set and there isn't a defaultProp for the width as a backstop for this situation.