search

tboothman / imdbphp

PHP library for retrieving film and tv information from IMDb
253 stars 84 forks source link

Replacement method for recommendations #159

Closed duck7000 closed 5 years ago

duck7000 commented 5 years ago

Re-worked recommendations method because i thought there where parts missing. The existing method parses only the first year, so in the case of year span (tv series) the closing year was not parsed. And the existing method didn't parse the text inside the year brackets

The output array contains 2 extra fields, endyear and type. endyear contains the endyear of example a tv series (if available). type contains the text that is sometimes displayed between the year brackets like video, tv series etc.

For existing users there are no changes if they don't want the extra features.

Edit: I used tabs but it was better to use spaces i guess?

tboothman commented 5 years ago

Yes you should've used spaces instead of tabs, but I'm going to reformat the whole codebase once this is merged so it's not a problem

duck7000 commented 5 years ago

Thanks a lot for the review!

tboothman commented 5 years ago

Changed this, btw: 660ff6dc5bcec1addec3dd2e9eca84828b70351c