Closed paxter closed 3 years ago
Thanks for the bug rapport.
1) wouldn't be a viable solution as it's hard to maintain and verify. I have made it in another project, but it's not perfect. See.
2) If it's okay by you if we can introduce mpaa(true)
as it would be a breaking change otherwise.
Thanks for the bug rapport.
You're welcome.
- wouldn't be a viable solution as it's hard to maintain and verify. I have made it in another project, but it's not perfect. See.
Hm yes, you're right. It's not so easy.
- If it's okay by you if we can introduce
mpaa(true)
as it would be a breaking change otherwise.
Would be ok for me, but it's up to you. But it's the best solution I think.
I just fixed it for myself by simply prevent overriding if the numeric certification is higher. Works for me, because I only need german certifications.
I made a PR to resolve this issue. Can You please review it? Thanks.
Steps to reproduce:
Result:
But there are multiple values for some countries: https://www.imdb.com/title/tt0436992/parentalguide The current mpaa() function overrides the previous value if there are multiple available.
Possible solutions: 1.) Always take the lowest certification as IMDb shows on the detailpage. But this will need a list for non numeric certifications to know whats lower or higher. For countries like germany it's easy to implement. 2.) List all available certifications.
Thanks for keeping this project alive!