search

tboothman / imdbphp

PHP library for retrieving film and tv information from IMDb
253 stars 84 forks source link

update locations method #226

Closed duck7000 closed 3 years ago

duck7000 commented 3 years ago
duck7000 commented 3 years ago

Thanks for your comments.

backwards compatible can't be achieved with 2 values, so atribute has to go then? Or i have to combine those 2 values in one string, which is also not backwards compatible.

I agree with the field names, although attribute doesn't say much what it stands for

duck7000 commented 3 years ago

I adjusted it back to what it was, so keep backwards compatible. I don't see a way to include attribute but keep backwards compatibility?

jreklund commented 3 years ago

The only way to not break backwards compatibility are to add params, to the method, to change the return type/behavior. In case that's not something you want to develop, you also need to revert the phpdoc block specifying @return as that part still specify the new code.

duck7000 commented 3 years ago

@jreklund Thanks for your feedback.

For now i leave it like it is, i have updated phpdoc.

duck7000 commented 3 years ago

@all Thanks for merging!