tboothman / imdbphp

PHP library for retrieving film and tv information from IMDb
253 stars 84 forks source link

Added method mainPictures back #248

Closed duck7000 closed 2 years ago

duck7000 commented 3 years ago

Maybe the if checks need some attention?

duck7000 commented 3 years ago

@jreklund Thanks for your comments.

Wow that's a lot issues, i'll look in to that

jreklund commented 3 years ago

It will work without most of the modifications, we will however save some microseconds and get cleaner code with these modifications thought. :)

Thanks the hard work you are putting into the library lately! <3

duck7000 commented 3 years ago

Cleaner code is absolutely fine, and i learned a lot lately here! Thanks!

Well i'm trying to make it better/more useful and better to understand (i hate preg_matches, very hard to understand) And i'm used to write code in a simple matter, so that i later on still understand what it does, although i perfectly understand ++ i still write it all out.

With your help i can get a long way to make/fix problems so i thank you too!

duck7000 commented 3 years ago

It might be a idea to include the image id in the output array? So in your application users can use that to name the images according to their imdb image id? It is just a thought

alr2413 commented 3 years ago

Is there any problem with this PR? I tested too. it's working.

duck7000 commented 3 years ago

As far as i know it is working but @jreklund haven't reviewed this any further. So i don't really know what is going on but there may be a valid reason for this?

@jreklund , @tboothman Can this PR and possibly my other PR's been reviewed? I do understand that it will cost your time, but it would be nice to make some valid changes to imdbphp? I'm just politely asking though

duck7000 commented 2 years ago

on request @Thomasdouscha i will reopen

duck7000 commented 2 years ago

This will need a test but i only do that after this is final reviewed.

duck7000 commented 2 years ago

@jreklund Last try, can/will you merge this or not?