search

tboothman / imdbphp

PHP library for retrieving film and tv information from IMDb
253 stars 84 forks source link

Method soundtrack updated #249

Closed duck7000 closed 2 years ago

duck7000 commented 3 years ago

Possible change: credits could be array, separating all credits lines? In that case it would be possible to select which credit line you want, although it has no value to me personally.

Suggestions and refinements are welcome, as this is a big change from what is in the current source of imdbphp. And yes the output array is different, but i doubt how many people actually use this method (i do) that would notice the difference. The soundtrack title is still the same in the output array afaik.

duck7000 commented 3 years ago

Is this even considered to be merged, as i fully understand that it will be a change? But i think it is a good change as this always works, the current method does not work in all cases.

duck7000 commented 3 years ago

Closing, lack of response

duck7000 commented 2 years ago

at request @Thomasdouscha reopen

duck7000 commented 2 years ago

I have personal interest in this method so it would be nice if we can make this work so everyone can use this method.

duck7000 commented 2 years ago

Returning soundtracks per line as is is not the way this library is supposed to work, and yes i have to agree with that so this method needs redone, strip as many types of credits to array elements is the way to go but that will make it more complicated.

duck7000 commented 2 years ago

Closing this one because it is no more relevant, the current soundtrack method is already changed, credits_raw is removed. Still this needs rethinking though, i'll try again