tboothman / imdbphp

PHP library for retrieving film and tv information from IMDb
253 stars 84 forks source link

Added new method main awards #269

Closed duck7000 closed 2 years ago

duck7000 commented 2 years ago

This method get only the awards info at the title page inside the yellow block. I made this because this is a simple version for if you only want this info instead of all awards (witch can be a lot of information)

It may be useful to others as well.

duck7000 commented 2 years ago

I'm aware that this needs a test, there never was one so i will, in time, to figure something out

duck7000 commented 2 years ago

I will make a test but after this is reviewed

duck7000 commented 2 years ago

I assume that there is no interest in this new method. If someone do report to this PR

If no response i will close this as it has no point if no one is interested. no harm feelings here

Thomasdouscha commented 2 years ago

it is interesting to me. I can test it. But give me the files than i will do it.

Thomasdouscha commented 2 years ago

1.test tt0068646 {"awards":"Won 3 Oscars","wins":"31","nominations":"30"} 2.test tt0120338 {"awards":"Won 11 Oscars","wins":"125","nominations":"83"} 3.test tt5034838 {"awards":"","wins":"2","nominations":"14"} 4.test tt6156584 {"awards":"","wins":"4","nominations":"22"} 5.test tt2560140 empty

It works quite well.

duck7000 commented 2 years ago

Okay that is nice to here you have interest and that it works.

I'm not sure @tboothman will merge this though, it means another extra method to maintain but if necessary i will do the maintenance

Thomasdouscha commented 2 years ago

I think he will merge it and it returns summarize info which exactly we needed. Thanks a lot @duck7000 ! Good job!

Thomasdouscha commented 2 years ago

@tboothman please let you merge it. Of course it is your call!

duck7000 commented 2 years ago

@tboothman , @jreklund Last try, can/will you merge this or not? Or at least give your opinion about this?

Thomasdouscha commented 2 years ago

It was working in my tests.