search

tboothman / imdbphp

PHP library for retrieving film and tv information from IMDb
253 stars 84 forks source link

test release info gives error #276

Closed duck7000 closed 2 years ago

duck7000 commented 2 years ago

Fixed Incorrect imdbid

duck7000 commented 2 years ago

@tboothman The imdbid used in this test appears to be wrong, leading 0 is missing, but if i add that zero the test fails again?

duck7000 commented 2 years ago

@tboothman There are more issues/differences in imdbid's used in the test methods: In titleTest.php: line 1571 -> $imdb = $this->getImdb('7618100'); (single quotes used) line 1611 -> $imdb = $this->getImdb(107290); (no quotes used, leading zero is missing but gives error when used) line 1653 -> $imdb = $this->getImdb("0306414"); (double quotes used)

So imho double quotes should be used as this represent a variable afaik? All though single quotes should work as well i guess.

tboothman commented 2 years ago

If you start a number with a 0 it's assumed to be an octal which means the value will be completely different

php > echo 010;
8

"123" is the same as '123'. The only difference in PHP is you can do string interpolation inside a "" string. e.g. $x = 456; echo "123$x".

I fixed this test failure myself, didn't spot your PR til i'd merged it