search

tboothman / imdbphp

PHP library for retrieving film and tv information from IMDb
247 stars 84 forks source link

PHP Warning: Undefined array key 1 in Title.php on line 2470 #317

Open jcvignoli opened 1 year ago

jcvignoli commented 1 year ago

Hi,

I get numerous warnings because of Title.php's trivia function.

I guess line 2470 should be if (isset($block[1]) && preg_match_all('!<div class="sodatext">\s*(.*?)\s*</div>\s*<div!ims', $block[1], $matches)) { instead of if (preg_match_all('!<div class="sodatext">\s*(.*?)\s*</div>\s*<div!ims', $block[1], $matches)) {

Thanks!

duck7000 commented 1 year ago

The trivia page is already converted to graphQL by imdb so it is a question of time when it completely stops working. i already converted triva to GraphQL so feel free to use it as a PR. but remember that there could be differences between this and my version check #314