search

tboothman / imdbphp

PHP library for retrieving film and tv information from IMDb
247 stars 84 forks source link

Is searching by type broken? #325

Closed Fossil01 closed 5 months ago

Fossil01 commented 7 months ago

I get all kinds of podcasts etc as results too while using 

$imdb->search('Blabla', [TitleSearch::MOVIE])

For example this one: https://www.imdb.com/title/tt23547604/ which shows as a "Podcast Episode" but comes back with #main_movietype: "Movie"

Also had this one just popup: https://www.imdb.com/title/tt28856207/ another podcast.

Fossil01 commented 7 months ago

Looks like it just needs some type(s) added as constants and in parseTitleType()

 elseif (strpos($string, 'PODCAST EPISODE') !== false) {
            return self::PODCAST_EPISODE;
        }
const PODCAST_EPISODE = 'Podcast Episode';
const PODCAST_SERIES = 'Podcast Series';
Fossil01 commented 7 months ago

https://github.com/tboothman/imdbphp/pull/326

duck7000 commented 7 months ago

There is a lot more broken with imdphp so good luck with this PR..

I don't think that tboothman has any more interest in this project

Fossil01 commented 7 months ago

Perhaps, but at least this fixes one issue. Using it now (forked it).

duck7000 commented 5 months ago

Well.. you are in luck that @jreklund merged your request but it still feels like flogging a dead horse to me

Fossil01 commented 5 months ago

Could you tag a new version as well please? :-)